work on #261: avoid hang #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See pionxzh#261 for the situation. This commit avoids errors caused by multimodal parts we don't understand. It does NOT add any functionality that understands advanced voice mode parts. Perhaps that should be broken out of pionxzh#261 into a separate enhancement request.
eslint error: error '&&' should be placed at the beginning of the line solution: move a trailing `&&` to the front of the next line
pionxzh
approved these changes
Oct 13, 2024
|
Thanks for the contribution! I will check how to properly handle the issue later. |
|
I will try to fix it today, if no, then I will release a new version with this fix |
any update on this? |
|
@peterkaminski @flowerpoweruk sorry I don't have much time to work on this. I just published the new version with this workaround. I will try to arrange a fix recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #261 for the situation. This PR avoids errors caused by multimodal parts we don't understand.
It does NOT add any functionality that understands advanced voice mode parts. Perhaps that should be broken out of #261 into a separate enhancement request.
I have tested this code under the same conditions as #261, and it doesn't hang anymore. The affected conversations are outputted with sections like this instead: