feat: upgrade codemirror 5 to codemirror 6 #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Nov 8, 2024
querybook/webapp/components/CodeMirrorTooltip/FunctionDocumentationTooltip.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/hooks/queryEditor/extensions/useAutoCompleteExtension.ts
Outdated
Show resolved
Hide resolved
querybook/webapp/hooks/queryEditor/extensions/useHoverTooltipExtension.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/hooks/queryEditor/extensions/useHoverTooltipExtension.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/hooks/queryEditor/extensions/useKeyMapExtension.ts
Outdated
Show resolved
Hide resolved
czgu
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the query editor to use codemirror6, changes cover below editor features and most of them will have the same user experience
some screenshots
linter error and summary status bar
table hover
auto complete
search highlight
