Implement Presto SQLGlot Optimizers #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
reviewed
Jul 27, 2023
querybook/server/lib/query_analysis/validation/validators/presto_optimizing_validator.py
Outdated
Show resolved
Hide resolved
querybook/server/lib/query_analysis/validation/validators/presto_optimizing_validator.py
Outdated
Show resolved
Hide resolved
| return Trino.Tokenizer().tokenize(query) | ||
|
|
||
|
|
||
| class BaseSQLGlotValidator(metaclass=ABCMeta): |
There was a problem hiding this comment.
will this base class only be used for the presto optimizing validators?
There was a problem hiding this comment.
Right now it's only used for Presto, but good point. I moved the BaseSQLGlotValidator to a separate file so it can be used for other custom implementations
Comment on lines
+150
to
+151
| end_line: number | null; | ||
| end_ch: number | null; |
There was a problem hiding this comment.
where are end_line and end_ch used?
There was a problem hiding this comment.
They'll be used in the upcoming UI PR (since we'll need start and end coordinates of text that needs to be changed)
jczhong84
approved these changes
Jul 28, 2023
kgopal492
added a commit
that referenced
this pull request
Aug 14, 2023
* Implement Presto SQLGlot Optimizers (#1300) Create a PrestoOptimizingValidator that extends the PrestoExplainValidator to run validators that provide suggestions to rewrite & optimize the query the query * Implement UI for query optimization suggestions (#1302) Create a new tooltip for users to accept query optimization suggestions * Update querybook version, fix PrestoOptimizingValidator (#1304) * Fix minor UI suggestions (#1305)
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* Implement Presto SQLGlot Optimizers (pinterest#1300) Create a PrestoOptimizingValidator that extends the PrestoExplainValidator to run validators that provide suggestions to rewrite & optimize the query the query * Implement UI for query optimization suggestions (pinterest#1302) Create a new tooltip for users to accept query optimization suggestions * Update querybook version, fix PrestoOptimizingValidator (pinterest#1304) * Fix minor UI suggestions (pinterest#1305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
PrestoOptimizingValidatorthat extends thePrestoExplainValidatorto run validators that provide suggestions to rewrite & optimize the query the queryNew suggestions being made to make query run more quickly:
APPROX_DISTINCT(x)instead ofCOUNT(DISTINCT x)LIKEclauses to useREGEXP_LIKEUNION ALLinstead ofUNIONSuggestions are made by tokenizing query using
sqlglotlibrary and searching for matching patternsUpdate query/validation endpoint's return type
QueryValidationResultto allow for a suggestion type (specifies start coordinate & end coordinate that is changed, and the suggestion text)Updated logic in Implement developer assistance query rewriting #1298 to return start/end coordinates of text to change, and a suggestion string