Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update generated client, fix tests and improve organic data #133

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

dfana01
Copy link
Contributor

@dfana01 dfana01 commented Aug 28, 2024

  • Add missing fields for models
  • Change conversation assert to validate the response code instead of the response since the endpoint changes the logic to fully validate em data
  • Delete only non-default pins
  • Add missing params to create methods
  • Disable client validation by default
  • Add get_all pins method

Run tests locally

Screenshot 2024-08-28 at 12 05 33 AM

rushabhvaria
rushabhvaria previously approved these changes Aug 28, 2024
pinterest/ads/campaigns.py Outdated Show resolved Hide resolved
@dfana01 dfana01 merged commit 2c25cfa into main Aug 28, 2024
5 of 6 checks passed
@dfana01 dfana01 deleted the fix-update-generated-client-n-fixed-tests branch August 28, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants