Update docs for google pages #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
byronantak
commented
Nov 5, 2024
byronantak
commented
- Update docs README.md for installation steps
- Update base url to point to the pages instance
- Update github url to point to correct repo
* Update base url to point pages instance * Update github url to point to correct repo
garionpin
approved these changes
Nov 5, 2024
maallen
approved these changes
Nov 5, 2024
garionpin
reviewed
Nov 5, 2024
| @@ -98,7 +98,7 @@ Depending on the file size that will be processed, it might be required to incre | |||
| max_allowed_packet = 256M | |||
|
|
|||
|
|
|||
| If using a older version of MySQL, there is a [known issue](https://github.com/box/mojito/issues/120) when creating the schema. One workaround is to use `utf8` | |||
| If using a older version of MySQL, there is a [known issue]({{ site.github_url }}/issues/120) when creating the schema. One workaround is to use `utf8` | |||
There was a problem hiding this comment.
@byronantak - I don't think that issue id exists in this fork - might need to be updated
There was a problem hiding this comment.
@garionpin Sorry. It put the automerge under the assumption that it worked like azure devops which blocks if there is an unresolved conversation. I fixed it in a follow-up PR
#181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.