I18N-1308: Fix circular DI for PreAuthFilter #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byronantak
changed the title
garionpin
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestHeaderAuthenticationFilterneeds anAuthenticationManageror else it throws some RunTimeException. The previous solution was to create a faked outAuthenticationManagerwhich just throws an Exception on the abstract method.Later on in the pipeline, the real
AuthenticationManageris buillt viaAuthConfigconfig. TheAuthConfigcannot be injected into theWebSecurityHeaderConfig.javabecause it builds a dependency of theAuthConfig. So it is circular in natureUltimately, a bean does not need to be registered for
requestHeaderAuthenticationFilter. It can be created when the appropriate HEADER auth type is selected. If it is created byWebSecurityConfig.java, theAuthConfig(and henceAuthManager) already exist, so a fakeAuthManagerdoes not need to be created and there is less confusion about where this auth mechanism gets its config from!