I18N-1297 - Temporarily block third-party sync for a Text Unit Variant #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarKhaos
force-pushed
the
I18N-1297
branch
7 times, most recently
from
482cfbb
to
ddf0bc3
Compare
DarKhaos
commented
Oct 22, 2024
| @@ -263,7 +263,8 @@ void importTextUnitsOfLocaleAndAsset( | |||
| textUnitForBatchImport.getStatus(), | |||
| textUnitForBatchImport.isIncludedInLocalizedFile(), | |||
| importTime, | |||
| importedBy); | |||
| importedBy, | |||
| true); | |||
There was a problem hiding this comment.
Does not update text unit variants with TRANSLATED_IN_MOJITO status
DarKhaos
commented
Oct 22, 2024
| noUpdate = true; | ||
| } | ||
| } | ||
|
|
||
| return new AddTMTextUnitCurrentVariantResult(!noUpdate, tmTextUnitCurrentVariant); | ||
| } | ||
|
|
||
| public AddTMTextUnitCurrentVariantResult addTMTextUnitCurrentVariantWithResult( |
There was a problem hiding this comment.
Method with existing parameters and behavior (checkTranslatedInMojito set to false)
DarKhaos
force-pushed
the
I18N-1297
branch
4 times, most recently
from
5e54348
to
484d36e
Compare
DarKhaos
requested review from
garionpin,
maallen,
byronantak and
mattwilshire
garionpin
reviewed
Oct 23, 2024
webapp/src/main/java/com/box/l10n/mojito/entity/TMTextUnitVariant.java
Outdated
Show resolved
Hide resolved
maallen
reviewed
Oct 23, 2024
| @@ -52,4 +52,6 @@ public enum StatusFilter { | |||
| * TextUnits that are not rejected, ie {@link TMTextUnitVariant#includedInLocalizedFile} is true. | |||
| */ | |||
| NOT_REJECTED, | |||
| /** TextUnits with status ({@link TMTextUnitVariant.Status#TRANSLATED_IN_MOJITO}). */ | |||
| TRANSLATED_IN_MOJITO, | |||
There was a problem hiding this comment.
Similar to previous comment around naming
| @@ -20,7 +20,8 @@ class TextUnitsreviewModal extends React.Component { | |||
| this.REVIEW = "review"; | |||
| this.REJECT = "reject"; | |||
| this.ACCEPT = "accept"; | |||
| this.TRANSLATE = "translate"; | |||
| this.TRANSLATE = "translate" | |||
| this.TRANSLATED_IN_MOJITO = "translated_in_mojito"; | |||
There was a problem hiding this comment.
Adding here to be tracked by naming conversation
DarKhaos
force-pushed
the
I18N-1297
branch
3 times, most recently
from
a3a1a0d
to
c8b72e7
Compare
garionpin
approved these changes
Oct 25, 2024
Added a new status to text unit variants and avoid updating them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new status to text unit variants and avoided updating them