I18N-1305: Added block list for Slack usernames that shouldn't receive branch notifications #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garionpin
reviewed
Oct 15, 2024
...src/main/java/com/box/l10n/mojito/service/branch/notification/BranchNotificationService.java
Show resolved
Hide resolved
maallen
reviewed
Oct 15, 2024
.../box/l10n/mojito/service/branch/notification/slack/BranchNotificationMessageSenderSlack.java
Outdated
Show resolved
Hide resolved
…ow IllegalStateException if an invalid regex is found
garionpin
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a block list to the application.properties that stops the Slack branch notifier from attempting to send messages to usernames in that list. Usernames are separated by commas and regex can be used in the block list to match names.
This is useful for ensuring bot accounts on GH can be excluded when attempting to send a Slack message.