I18N-1291 - Mojito user management table should be searchable #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byronantak
reviewed
Oct 9, 2024
webapp/src/main/resources/public/js/components/common/SearchText.js
Outdated
Show resolved
Hide resolved
webapp/src/test/java/com/box/l10n/mojito/service/security/user/UserServiceTest.java
Show resolved
Hide resolved
DarKhaos
force-pushed
the
I18N-1291
branch
2 times, most recently
from
2fbdb72
to
6bde22e
Compare
maallen
reviewed
Oct 10, 2024
webapp/src/main/java/com/box/l10n/mojito/service/security/user/UserRepository.java
Outdated
Show resolved
Hide resolved
DarKhaos
force-pushed
the
I18N-1291
branch
3 times, most recently
from
30d15b9
to
90e0c36
Compare
maallen
approved these changes
Oct 11, 2024
byronantak
reviewed
Oct 11, 2024
| this.waitFor(UserSearchParamStore); | ||
|
|
||
| const currPage = 0; | ||
| const pageSize = 10; |
There was a problem hiding this comment.
Nit: I understand why we set the current page to 0 when the search term changes, but it would be nice to have the user's selected page stay the same even if they search again
Made user management table searchable
byronantak
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made user management table searchable