Add multi Quartz scheduler functionality #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maallen
commented
Aug 24, 2023
aurambaj
reviewed
Aug 24, 2023
webapp/src/main/java/com/box/l10n/mojito/quartz/QuartzPollableTaskScheduler.java
Outdated
Show resolved
Hide resolved
aurambaj
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Very promissing, nice!! I'll do some more review later when the configuration is refactored but that seems pretty much it. You may want to re-split the PR in independent/smaller commits like reading just the config, creating the instance and then updating the integration points
webapp/src/main/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerConfigProperties.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerConfigProperties.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerConfigProperties.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerConfigProperties.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerFactory.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerManager.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerManager.java
Outdated
Show resolved
Hide resolved
maallen
force-pushed
the
allow_disable_quartz_scheduler
branch
from
5b7fd33
to
ccda63b
Compare
maallen
force-pushed
the
allow_disable_quartz_scheduler
branch
from
ccda63b
to
bb7bac4
Compare
aurambaj
reviewed
Aug 25, 2023
...t/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerConfigurationPropertiesTest.java
Outdated
Show resolved
Hide resolved
.../main/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerConfigurationProperties.java
Outdated
Show resolved
Hide resolved
.../main/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerConfigurationProperties.java
Outdated
Show resolved
Hide resolved
...t/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerConfigurationPropertiesTest.java
Show resolved
Hide resolved
...t/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerConfigurationPropertiesTest.java
Outdated
Show resolved
Hide resolved
aurambaj
reviewed
Aug 25, 2023
.../main/java/com/box/l10n/mojito/quartz/multi/QuartzMultiSchedulerConfigurationProperties.java
Show resolved
Hide resolved
maallen
force-pushed
the
allow_disable_quartz_scheduler
branch
from
bb7bac4
to
2a764c6
Compare
aurambaj
pushed a commit
that referenced
this pull request
Sep 2, 2023
This PR adds functionality to allow the configuration of multiple Quartz schedulers and introduces configuration properties to allow jobs to be scheduled to a specified Quartz scheduler. Updates the docker-compose file docker-compose-api-worker.yml to spin up a single db & mojito api container alongside two mojito worker containers used to execute the Quartz jobs which can be utilised for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to allow the configuration of multiple Quartz schedulers and introduces configuration properties to allow jobs to be scheduled to a specified Quartz scheduler.
Updates the docker-compose file
docker-compose-api-worker.ymlto spin up a single db & mojito api container alongside two mojito worker containers used to execute the Quartz jobs which can be utilised for testing.