Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code change to support public 'SetPrincipal' method #98

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Code change to support public 'SetPrincipal' method #98

merged 2 commits into from
Sep 1, 2023

Conversation

vedantr
Copy link
Member

@vedantr vedantr commented Sep 1, 2023

  • In the event that Knox users wish to have a 3rd-party authentication plugin, simplify the code such that users can set a custom principal implementation but still be able to use built-in decorators (e.g. the Logging decorator, which embeds user identity in the logs)

@krockpot krockpot merged commit f6207c8 into pinterest:master Sep 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krockpot krockpot krockpot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vedantr @krockpot