Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPM define #574

Merged
merged 14 commits into from
Oct 7, 2020
Merged

SPM define #574

merged 14 commits into from
Oct 7, 2020

Conversation

3a4oT
Copy link
Contributor

@3a4oT 3a4oT commented Oct 6, 2020 •
edited
Loading

@3a4oT 3a4oT mentioned this pull request Oct 6, 2020
Open
3 tasks
@Kaspik Kaspik mentioned this pull request Oct 7, 2020
Closed
garrettmoon
garrettmoon approved these changes Oct 7, 2020
View reviewed changes
Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for fixing!

@garrettmoon garrettmoon merged commit 66af9b2 into pinterest:master Oct 7, 2020
@3a4oT 3a4oT deleted the spm branch October 7, 2020 17:46
@3a4oT 3a4oT restored the spm branch November 17, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3a4oT @garrettmoon