Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] fix: datepicker's maxrange validation #11722

Conversation

BillionaireDY
Copy link
Contributor

  • Do not update the date state and display a warning if the maxRange is exceeded.

@jihea-park
Can you conduct various tests on this issue?

@jihea-park
Copy link
Contributor

@BillionaireDY
VERY GOOD!!!!!

Copy link
Contributor

@jihea-park jihea-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.87%. Comparing base (d66cda6) to head (c5fd0d9).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11722      +/-   ##
============================================
- Coverage     36.88%   36.87%   -0.02%     
+ Complexity    12404    12395       -9     
============================================
  Files          4106     4105       -1     
  Lines        100725   100714      -11     
  Branches      10559    10557       -2     
============================================
- Hits          37154    37138      -16     
- Misses        60556    60561       +5     
  Partials       3015     3015              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jihea-park jihea-park merged commit c350c48 into pinpoint-apm:master Nov 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants