docs->add appsignal pino transport #2065
Open
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
is it covered by tests? does it have docs? |
mcollina
reviewed
Oct 17, 2024
docs/transports.md
Outdated
|
|
||
| const logger = pino({ | ||
| AppsignalPinoTransport({ | ||
| client: Appsignal.client, |
There was a problem hiding this comment.
I don't think this would work with pino-transport
There was a problem hiding this comment.
Could you provide more info about how it wouldn't work with pino-transport please? I'm trying to find some info about it, but I haven't found anything.
There was a problem hiding this comment.
Hi @mcollina! Now it's compatible with pino-transport. I've updated the PR.
Yes, we have a test-setup for it working with Fastify Pino logging: https://github.com/appsignal/test-setups/blob/main/nodejs/fastify/app/src/app.ts And its docs page: https://docs.appsignal.com/logging/platforms/integrations/nodejs.html#usage-with-pino |
jsumners
requested changes
Oct 18, 2024
jsumners
approved these changes
Oct 19, 2024
luismiramirez
force-pushed
the
doc-pino-appsignal
branch
from
63a8fcd
to
f7845ca
Compare
luismiramirez
force-pushed
the
doc-pino-appsignal
branch
from
f7845ca
to
af75f90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! 👋🏼
We've created an AppSignal pino transport and recently released it as part of our v3.5.1 integration.
This PR adds the transport to the v7+ compatible list.