fix: unescape \\ for levelKey #538
Merged
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliw00d
commented
Nov 4, 2024
| typeof log[key] === 'boolean' | ||
| }) | ||
| ] | ||
| .map((key) => key.replaceAll(/\\/g, '')) |
There was a problem hiding this comment.
This strips off the \\ in log\\.level so that you get the correct key to ignore.
eliw00d
commented
Nov 4, 2024
| const formatted = pretty(chunk.toString()) | ||
| t.equal( | ||
| formatted, | ||
| `[${formattedEpoch}] WARN (${pid}): foo\n` |
There was a problem hiding this comment.
Without this fix, you would get log.level underneath in the prettified object.
|
@mcollina Pino 9.0.0 dropped support for Node 14. Is that something that can be done here as well? I can switch to |
|
Yes, we should drop 14. It'll be a new major, though. |
Should I make that change in this PR? For example: matrix:
node-version: [18.17, 20, 22]
os: [ubuntu-latest]
pino-version: [^9.0.0] |
|
@eliw00d send a fresh PR. |
jsumners
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #456