Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

a #13

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,38 +24,38 @@ can make pull requests to that repo during the Task 3 activity during the lab.
During lab, you should not fork directly from https://github.com/CSC207-2023F-UofT/Lab2.
If you miss the lab and work on this after, you should use this URL though.

- [ ] Make a fork of this repo and clone a local copy (as you did in Lab 1).
- [x] Make a fork of this repo and clone a local copy (as you did in Lab 1).
- Important: make sure to uncheck the option to only fork the main branch, as the repo
contains some branches you will use in this lab.

# TASK 1: Your first branch

- [ ] Create and checkout a new branch called `task_1` using either IntelliJ or the Terminal:
- [x] Create and checkout a new branch called `task_1` using either IntelliJ or the Terminal:
- IntelliJ: `Git -> New branch...`
- Terminal: `git checkout -b task_1`
- After, you can check `git status` or the Log tab of the Git tool window in IntelliJ to see
that you are now on the `task_1` branch.
- [ ] Open the TODO tool window (`View -> Tool Windows -> TODO`) and click on the TASK 1 TODO listed.
- [ ] Complete the TASK 1 TODO and commit your changes to this file (checking off the
- [x] Open the TODO tool window (`View -> Tool Windows -> TODO`) and click on the TASK 1 TODO listed.
- [x] Complete the TASK 1 TODO and commit your changes to this file (checking off the
completed items so far) and `DataTypes.java` (remove the word TODO and your bug fix).
- talk to those around you or your TA, then see the hints at the bottom of the readme if you get stuck.
- [ ] Now, we'll merge the `task_1` branch back into `main`. When merging,
- [x] Now, we'll merge the `task_1` branch back into `main`. When merging,
you need to be currently on the branch you are trying to merge into, so we'll first checkout the main
branch:
- IntelliJ: `Git -> branches... -> main -> Checkout`
- Terminal: `git checkout main`
Note: everything we've done has been local to our repository and have not pushed anything yet.
- [ ] We are back on `main`, so we can now do the merge and complete our work!
- [x] We are back on `main`, so we can now do the merge and complete our work!
- IntelliJ: `Git -> Merge... -> task_1 -> Merge`
- Terminal: `git merge task_1`

You should now see the changes you had made are also in the `main` branch.

- [ ] Now, we'll want to clean up since we are done with our `task_1` branch.
- [x] Now, we'll want to clean up since we are done with our `task_1` branch.
- IntelliJ: `Git -> branches... -> task_1 -> Delete`
- Terminal: `git branch -d task_1`

- [ ] Last step, we'll push our changes to the remote repository to share our work! (As we did in Lab 1.)
- [x] Last step, we'll push our changes to the remote repository to share our work! (As we did in Lab 1.)
- we suggest you check off this last item, commit that change (just right on main is fine;
no need to branch for this little step), then push your code. Check GitHub to ensure you can
see your changes.
Expand Down
3 changes: 1 addition & 2 deletions src/DataTypes.java
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import java.util.List;

public class DataTypes {
// TODO TASK 1: fix this code so that it passes the test in DataTypesTest.java
public static long sum(List<Integer> numbers) {

int s = 0;
long s = 0;
// below is a "foreach" loop which iterates through numbers
for (int x : numbers) {
s += x;
Expand Down