Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use epoch seconds to allow applying timezone offset #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blech
Copy link

@blech blech commented Dec 31, 2024

I live in the US so the word clock example wasn't showing the right time. Now it does.

This is obviously not great, because it doesn't handle DST. But at least now there's a place to change it twice a year.

@blech
Copy link
Author

blech commented Dec 31, 2024

I just noticed that vector_clock uses time.localtime() and that seems to do the right thing (although I'm not sure how). Maybe I'll look into that instead; it'd work around DST issues too.

@blech
Copy link
Author

blech commented Dec 31, 2024

I also see that #28 includes time zone fixes as well as a bunch of other changes, so if you want to prefer that one, closing this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant