Fix Button class on Pico 2W #1043
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just picked up a Pico 2W and GFX Pack to dip my toes into Raspberry Pi microcontrollers. While experimenting, running the button demo didn't work. I stumbled upon a few forum threads and eventually discovered #1041
This pull request modifies the
Buttonclass to specify the mode of thePinobject created within and, in my testing, this seems to fix the original example/built-in functionality that #1041 bypasses by locally creatingPinobjects.Note: I don't have the hardware to test this on any other Picos, so I only verified on my Pico 2W.