Ensure log truncations are at nearest newline after truncation size #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed #41 and found that it didn't behave consistently.
The behaviour expected is to truncate the file at the new line immediately after the truncation break point is reached. This means the truncation is always at least as small as requested. There is also cases at the start and end of file in #41 that do not behave rationally.
I would recommend this PR instead of #41.
Run the test cases with:
python -m unittest tests/*_test.py -v
Here is the test case results from #41 using the unit tests from this PR: