Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookworm/Pi5 Compatibility: Upgrade to latest boilerplate #9

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

Gadgetoid
Copy link
Member

Testing

If you're a Bookworm / Pi 5 user running into virtual environment issues, you can try this library like so:

git clone https://github.com/pimoroni/inventorhatmini-python -b feature/pi5
cd inventorhatmini-python
./install.sh --unstable

The ./install.sh script will create a pimoroni virtual environment that's shared between our products. (or use your existing venv if you've already activated one.)

For the reasons behind these changes and other information, see:

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9399972359

Details

  • 28 of 38 (73.68%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 56.051%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inventorhatmini/plasma.py 2 5 40.0%
inventorhatmini/init.py 11 18 61.11%
Totals Coverage Status
Change from base Build 4699330010: 0.3%
Covered Lines: 176
Relevant Lines: 314

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9400012135

Details

  • 28 of 38 (73.68%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 56.051%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inventorhatmini/plasma.py 2 5 40.0%
inventorhatmini/init.py 11 18 61.11%
Totals Coverage Status
Change from base Build 4699330010: 0.3%
Covered Lines: 176
Relevant Lines: 314

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9400065799

Details

  • 28 of 38 (73.68%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 56.051%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inventorhatmini/plasma.py 2 5 40.0%
inventorhatmini/init.py 11 18 61.11%
Totals Coverage Status
Change from base Build 4699330010: 0.3%
Covered Lines: 176
Relevant Lines: 314

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9400429436

Details

  • 32 of 39 (82.05%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 56.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inventorhatmini/init.py 17 24 70.83%
Files with Coverage Reduction New Missed Lines %
inventorhatmini/init.py 1 51.13%
inventorhatmini/plasma.py 4 44.44%
Totals Coverage Status
Change from base Build 4699330010: 0.4%
Covered Lines: 177
Relevant Lines: 315

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9400467604

Details

  • 32 of 39 (82.05%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 56.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inventorhatmini/init.py 17 24 70.83%
Files with Coverage Reduction New Missed Lines %
inventorhatmini/init.py 1 51.13%
inventorhatmini/plasma.py 4 44.44%
Totals Coverage Status
Change from base Build 4699330010: 0.4%
Covered Lines: 177
Relevant Lines: 315

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9401640304

Details

  • 32 of 39 (82.05%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 56.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inventorhatmini/init.py 17 24 70.83%
Files with Coverage Reduction New Missed Lines %
inventorhatmini/init.py 1 51.13%
inventorhatmini/plasma.py 4 44.44%
Totals Coverage Status
Change from base Build 4699330010: 0.4%
Covered Lines: 177
Relevant Lines: 315

💛 - Coveralls

@Gadgetoid Gadgetoid merged commit fc4b4bd into main Jun 6, 2024
7 checks passed
Copy link

github-actions bot commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9401961239

Details

  • 33 of 40 (82.5%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 56.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inventorhatmini/init.py 18 25 72.0%
Files with Coverage Reduction New Missed Lines %
inventorhatmini/init.py 1 51.13%
inventorhatmini/plasma.py 4 44.44%
Totals Coverage Status
Change from base Build 4699330010: 0.4%
Covered Lines: 177
Relevant Lines: 315

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9401961239

Details

  • 33 of 40 (82.5%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 56.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inventorhatmini/init.py 18 25 72.0%
Files with Coverage Reduction New Missed Lines %
inventorhatmini/init.py 1 51.13%
inventorhatmini/plasma.py 4 44.44%
Totals Coverage Status
Change from base Build 4699330010: 0.4%
Covered Lines: 177
Relevant Lines: 315

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants