Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataObject]: Add endpoint to list data object layouts #520

Merged
merged 2 commits into from
Oct 28, 2024
Merged

[DataObject]: Add endpoint to list data object layouts #520

merged 2 commits into from
Oct 28, 2024

Conversation

lukmzig
Copy link
Contributor

@lukmzig lukmzig commented Oct 28, 2024

Changes in this pull request

Part of pimcore/studio-ui-bundle#265

Additional info

  • Added endpoint to list layouts for data objects
  • properties might need to be adjusted based on the FE feedback
  • custom layouts need to be implemented still and considered before returning final response

@lukmzig lukmzig self-assigned this Oct 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 28, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lukmzig lukmzig requested a review from martineiber October 28, 2024 12:31
martineiber
martineiber approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦭

@lukmzig lukmzig merged commit c8d4bb5 into 1.x Oct 28, 2024
12 checks passed
@lukmzig lukmzig deleted the 265-data-object-editor---build-layouts branch October 28, 2024 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@martineiber martineiber martineiber approved these changes

Assignees

@lukmzig lukmzig

Labels
New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukmzig @martineiber