Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Rename and move Csv enums #505

Merged
merged 2 commits into from
Oct 18, 2024
Merged

[Task] Rename and move Csv enums #505

merged 2 commits into from
Oct 18, 2024

Conversation

mattamon
Copy link
Contributor

Changes in this pull request

Resolves #504

Additional info

Enums were suitable in many more places than just CSV

Copy link

sonarcloud bot commented Oct 17, 2024

Copy link
Contributor

@lukmzig lukmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) 🍸

@mattamon mattamon merged commit 505ea58 into 1.x Oct 18, 2024
12 checks passed
@mattamon mattamon deleted the 504-move-csv-constants branch October 18, 2024 05:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Move constants out of Csv to a more suitable class
2 participants