Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Add batch edit based on folder ids #496

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Conversation

mattamon
Copy link
Contributor

Changes in this pull request

Resolves #494

Additional info

Adding new endpoint to batch edit data from elements based on folder id

@mattamon mattamon added the Task label Oct 16, 2024
@mattamon mattamon marked this pull request as draft October 16, 2024 08:04
@mattamon mattamon marked this pull request as ready for review October 16, 2024 09:10
@mattamon mattamon requested a review from lukmzig October 16, 2024 12:08
Copy link
Contributor

@lukmzig lukmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks LGTM 🦭

@mattamon mattamon marked this pull request as draft October 17, 2024 06:18
Copy link

sonarcloud bot commented Oct 17, 2024

@mattamon mattamon marked this pull request as ready for review October 17, 2024 06:36
@mattamon mattamon requested a review from lukmzig October 17, 2024 06:36
@mattamon
Copy link
Contributor Author

@lukmzig sorry I forgot to add the filters so I had to refactor it again.
I do however see a problem with the constants for the Generic Execution Engine. I do not like the current position, so I will move it to a more fitting place with a separate PR if that is okay.

@mattamon mattamon merged commit ee153b7 into 1.x Oct 17, 2024
12 checks passed
@mattamon mattamon deleted the 494-batch-edit-folder branch October 17, 2024 06:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add endpoint to Batch-Edit whole folder
2 participants