Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding optional events (split, capital and div) #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CauaMatheus
Copy link

Today at work i had to fetch some data from yahoo, i used this lib to do this. But when i was trying to fetch the stock splits, i was not able to select the type. So this pull request was made to resolve this problem.

This pull request its just to the people be able to select the type of events they wanna fetch, can be "split", "div", "capital" and by default "history"

@gadicc
Copy link
Collaborator

gadicc commented Aug 23, 2021

Hey @CauaMatheus, thanks for this.

Regrettably as mentioned in the README, v1 of the library has been feature frozen since April.

As it happens however, v2 has a similar limitation in the historical module, although this pull request addresses it. It has a nice workaround which actually can retrieve all event types in a single network request (using the chart API under the hood).

Anyway since your change is so simple, let's leave this open for now and see what happens :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants