Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arduino IDE compatible #3

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Arduino IDE compatible #3

wants to merge 44 commits into from

Conversation

latchdevel
Copy link

Hi.

I want to share the Arduino compatible version of "pilight-usb-nano" firmware.
The sketch is ready to use with standard Arduino IDE and runs on any Arduino compatible board.

The original main code hardly changes, it is essentially the same, so the operation will be practically the same as the original, maybe with greater accuracy.
Only the power saving settings have been removed as they are not very useful on a USB powered device.

I added a GitHub Action to ensure it compiles correctly on different platforms like as AVR, SAM boards (32-bit ARM Cortex-M3), SAMD boards (32-bit ARM Cortex-M0+), and ESP8266.
https://github.com/latchdevel/pilight-usb-nano/actions/workflows/CompileTests.yml

I think it is more useful and easier to use than the current version. I hope it can merge to master branch.
Let me know if you need any additional explanation or any changes are necessary.

Best regards.

@latchdevel
Rename file to folder name and change main file extension to .ino
61d6a2a
@latchdevel
Set VERSION to 2 and add a license mention
86d5757
@latchdevel
First functional build with Arduino IDE that includes "wiring.c"
f296165 
- Add verification for AVR ATmega328p MCU and 16Mhz clock
- Remove duplicate delayMicroseconds() function
- Fix TIMER2 settings because it's changed by "wiring.c"
- Add void loop() function
@latchdevel
Change serial UART init and RX interrupt hander to Arduino style.
9d78816
@latchdevel
Change serial UART TX to Arduino style
e0f0db9
@latchdevel
Change RF RX ISR to Arduino style configurable pin
0b8c7e7
@latchdevel
Change RF TX output to Arduino style configurable pin
d7a8053
@latchdevel
Remove power save settings
1aa73e7
@latchdevel
Initialize plstypes array to zero at declare time
9640a07
@latchdevel
Replaces 10us custom Timer2 ticks to standard Arduino micros() function
712f073
@latchdevel
Adds all boards support
8f4dc38
@latchdevel
Update Readme file
7ca2160
@latchdevel
Remove redundant includes
3ec280c
@latchdevel
Remove global vars codelen and repeats
65e6bc0
@latchdevel
Remove unused vars
41452c2
@latchdevel
Add precompiler option to include stripped spaces
849b67d
@latchdevel
Move broadcast() to loop()
f13b236
@latchdevel
Move receive() to loop()
dd13b77
@latchdevel
Add support to led blink on valid RX
07d2e64
@latchdevel
Add support to sets valid RX settings at boot
fa63ecd
@latchdevel
Update Readme.md
9ee31d1
@latchdevel
Fix compiler warnings, and others cosmetics
0e44e7d
@latchdevel
Add "Compile tests" GitHub Action
dd65006
@latchdevel
Add compile tests action status badge
bc7e90f
@CurlyMoo
Copy link
Contributor

Always great if someone has the guts to do things completely different 👍

Before giving a opinion on the changes, can you add a proper diff between the two versions?

@latchdevel
Copy link
Author

Its operation is the same, all the original features have been implemented and the new additions have been left as optional.
But there are important differences between the two firmware implementations:

MCU / Board:

  • The previous version requires a MCU AVR ATmega328p at 16Mhz.
  • The new version can work on any compatible MCU / Arduino board, this is almost any MCU at almost any clock speed.

Compiler / Uploader:

  • The previous version requires building the firmware from the command line, in addition to the flasher program, so it is necessary to install several software packages (or have knowledge of AVR Studio or other professional development and flasher tools).
  • The new version can be built with the Arduino IDE and flashed on any board with just one "click".

I think these changes warrant a major version update after 6 years. So I switched to version 2, but it really works the same (or just a little better), so it may not be correct.

@CurlyMoo
Copy link
Contributor

The new version can work on any compatible MCU / Arduino board, this is almost any MCU at almost any clock speed.

With what tests have you confirmed this statement?

latchdevel and others added 15 commits May 10, 2021 16:14
@latchdevel
Add maxgaplen check, and improve long pulses accuracy
8e803a9
@latchdevel
Add maxgaplen check also in RX, and clear buffer in TX
04a9a06
@latchdevel
Optimize size of maxgaplen from uint32_t to unit16_t
0316341
@latchdevel
Optimize size of mingaplen from uint32_t to unit16_t
f5c19c7
@latchdevel
Optimize size of minrawlen and maxrawlen from uint32_t to uint8_t
771c4df
@latchdevel
Increased mingaplen because Maclean protocol (ELECTRO DH 60.531/M) ha…
f9d1fd5 
…ve pulses arround 3500 usecs
@latchdevel
Remove interrupt management for better RX
638a211
@latchdevel
Tune MIN_PULSELENGTH to 6, for 100 usec minimal pulse
6ff047f
@latchdevel
Reduce MAX_PULSELENGTH to maxgaplen initial setting
0bde571
@latchdevel
Update .gitignore file
f885f2f
@latchdevel
Add support to configure a tx enable pin (PTT_PIN)
4d20d83
@latchdevel
Fix serialEvent() ISR call unimplemented
a96f2e3
@latchdevel
Fix ISR_RX() ram attribute on ESP8266 and ESP32
1b20d45
@latchdevel
Add Compile Test for ESP32 platform
ee6fe2d
@latchdevel
Change --warnings from 'all' to 'none'
6579e79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@latchdevel @CurlyMoo