Bug fix #37
Merged
Bug fix #37
+140
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix implementation of "with_USA" and change use_USA_def_for_all argument to use_USA_cf_for_all.
johanneskoch94
requested review from
LaviniaBaumstark,
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q and
fbenke-pik
fbenke-pik
approved these changes
Oct 10, 2024
LaviniaBaumstark
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
replace_NAs = "with_USA"now does the following:It can also be used in combination with "linear":
replace_NAs = c("linear", "with_USA").