Allow using 'source' for app icon #759
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
requested changes
Oct 11, 2022
Comment on lines
+96
to
+101
| Object.keys(mediaIconMapping).forEach((attribute) => { | ||
| var app = entity.attributes[attribute]?.toLowerCase(); | ||
| if (app) { | ||
| icon = mediaIconMapping[attribute][app]; | ||
| } | ||
| }); |
There was a problem hiding this comment.
It's not clear about the rules priority because it depends of the order of the attributes.
I think we can do like this (I just wrote a pseudo code but you got the idea 🙂)
for each app_name
if app_name === entity.attribute.app_name:
return app_name icon
for each source
if app_name === entity.attribute.source:
return source icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows integrations which use
sourcerather thanapp_nameto be given an app iconRelated Issue
Closes #758
Motivation and Context
Users may not want to use the full app picture but instead have an icon that fits in with the HA UI so they can use the icon. Some integrations didn't provide an
app_nameattribute for this, but instead usessourceHow Has This Been Tested
Locally using the instructions in README.md to develop against HA.
Types of changes
Checklist