Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fan auto control #170

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davidhazell
Copy link

I wanted the ability to set my Levoit and Dyson fans to auto speed so I added a button for this on the mushroom fan card.

@davidhazell
Copy link
Author

davidhazell commented Feb 28, 2022

Screenshot 2022-02-27 231020

Copy link
Owner

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's for your PR.
I feel like it's more preset mode than auto mode.
Your fan only support auto mode. Mine support two presets :

  • Nature
  • Normal

Maybe we can find a way for the user to select the mode ?

@davidhazell
Copy link
Author

I thought about doing that but thought the UI may get too busy for the minimalist style and figured auto was a common option like oscillate. I suppose I could do something similar to the light card 'temperature' and 'color' buttons that repurpose the slider area.

Maybe a "preset_mode" button that displays the available presets where the slider normally is? My only concern is for fans with many presets available and fitting the buttons.

I could also make the 'auto' button a configurable 'preset_mode' button where the user defines a single preset mode to be set (auto, sleep, nature, etc) and allow the user to configure the icon.

What do you think?

@piitaya
Copy link
Owner

piitaya commented Mar 2, 2022

Hi ! With @bemble, we are discussing about how we can create the climate card with hvac_mode and preset_mode. I think it can be a good thing to have something similar for the fan preset_mode.

@davidhazell
Copy link
Author

I agree. It might make sense to have a similar design for each card's preset_mode selection interface whether that's a dropdown selection, individual buttons, etc to keep the interface consistent. Have @bemble and you discussed how you'd like to display preset_mode selection?

@mihailescu2m
Copy link

Any progress on this?
Using chips for presets?

@robert4y
Copy link

Add the remaining time until the fan turns off when the timer is running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants