-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom buttons to template-card #1422
base: main
Are you sure you want to change the base?
Add custom buttons to template-card #1422
Conversation
9c1c433
to
be52ce6
Compare
For information, up to what level are the button customisable ?
Whatever the customization, Many Thanks @martindybal and I hope it goes up to release ! |
@BBE-FR Thank you very much for your feedback and support! Regarding your questions: Dynamic icon/color: This is not supported in the current PR, but can be easily added if needed. Before I proceed with these additions, I need to hear from @piitaya if he wants to finish this PR. Thanks for your suggestions. |
Hi 🙂 Also I have concerns to bring new features like this to Mushroom because the gap between Mushroom and tile card become less important with HA updates. Many features request (icon tap action, card features, inverted cover slider, etc...) to Mushroom are improvements done to the tile card so it become hard to do the work in double. I have some options but I didn't decided about the best solution :
The problem with adding this option is that it will encourage people to not use tile card and it can lead to more breaking changes in the future if we want to fully merge Mushroom with Home Assistant. |
@piitaya I imagine that the question is hard... Option 1 would be Nice... The lack of template card and chips are the only real things that make me stay with mushroom... without template its difficult to go back to tiles... For the rest tiles are sligtly less customisable but its enought for 99% of time... |
+1 for Option 1 ... I would love to switch over to Tile Card 100% but am a heavy user of template and chip. |
@piitaya I fully understand. The reason for 4 elements is layout, but it's not a problem to use an array with limited size. I'm just not sure about the UI editor. I have no problem helping with the development of the Tile Card. I've switched to it myself in a few scenarios with mushrooms. My main reason for sticking with Mushrooms is
I'm using combination of Mushrooms and tile card for all my room like this |
@piitaya If not planed it might be worth to release this feature, I think there is a long lasting request for this kind of function in the mushroom Community. Y think we are numerous to use stack in to fuse template cards (or other mushroom when template is not mandatory) with chips to create additional buttons. If planned, there is an HACS project to allow to use controls: https://github.com/Nerwyn/service-call-tile-feature this could be embeded into the "template tile" to allow to define buttons into this future "advanced templatable tile". But it would be nice to make it as simple to use as a tile or mushroom feature (with GUI support). |
I used chips instead of button with stack in in my cards in order to keep the mushroom look and to have the ability to define the button through graphical interface (including full control of the icons/colors through the template chips)... @martindybal Your proposal is already a great improvement and I fully support this. If at the end you manage to have the same capacity than chips, that would be 100% marvelous to me ! |
@piitaya can you please comment? Does it make sense to continue on this or would TileCard be the future? |
Sorry for the late reply, I was busy these days. For now, I would say we close this PR and I will work on a "advanced" version of the card but I have no deadline to share... However, I personally only use Mushroom card for the template card so I would love to move forward 😅 |
This might be a way to advance on the subject: One option could be:
I think that otherwise, there will always be pros and cons to stay with mushroom "classical" cards and some will never migrate to tiles. My personal example is as follow:
With the latest badges (especially if they can be placed on top of sections) I could get rid of chips and use only Tiles. The last real functional blocking point for me is templating capability in Tile or Tile-like card... |
Description
Related Issue
This PR fixes or closes issue: fixes #
#887
#1421
Motivation and Context
As I mentioned in the last issue, I was a bit limited by the template card in some scenarios. It would be really great if I could have a quick action directly on my dashboard.
How Has This Been Tested
I tested it locally on my HA instance. I also created a sample in the dev box at
/lovelace-mushroom-showcase/5
.Types of changes
Checklist