Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vietnamese translations #1283

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Update Vietnamese translations #1283

merged 2 commits into from
Nov 16, 2023

Conversation

vinhtantran
Copy link
Contributor

Description

Add Vietnamese translations for phrases added since its last edits.

Related Issue

This PR fixes or closes issue: none

Motivation and Context

An outdated Vietnamese translations and spotted English phrases in the current version.

How Has This Been Tested

Carefully check the brackets and places.

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

@piitaya
Copy link
Owner

piitaya commented Nov 16, 2023

The build doesn't pass, the json is not valid.

@vinhtantran
Copy link
Contributor Author

The build doesn't pass, the json is not valid.

Thank you. There was an excess comma towards the end that makes JSON invalid. It has been fixed and the format has been validated.

@piitaya
Copy link
Owner

piitaya commented Nov 16, 2023

Perfect ! Thanks !

@piitaya piitaya merged commit 065b544 into piitaya:main Nov 16, 2023
1 check passed
@piitaya piitaya added the translations Translations label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants