Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Major refactoring #1

Merged
merged 20 commits into from
Sep 26, 2017
Merged

Conversation

andreamattavelli
Copy link
Collaborator

This pull request attempts to better organize the code and automatize the build of SUSHI.

Some comments:

  1. I've incorporated the code of sushi and sushi-lib. They are now referred to as master and runtime.
  2. I've also incorporated JBSE as git submodule, since SUSHI is closely linked to it.
  3. I've created a Maven pom.xml to build the projects.

This PR depends on pietrobraione/jbse#8

@pietrobraione pietrobraione self-assigned this Sep 20, 2017
@pietrobraione
Copy link
Owner

OK for the general idea, but I would like not to lose the history of the sushi-lib project, so I would leave it in its own repository and incorporate it as a submodule.

@andreamattavelli
Copy link
Collaborator Author

@pietrobraione Done.
This PR now depends on pietrobraione/sushi-lib#2 and cannot be merged until then.

@pietrobraione
Copy link
Owner

Reckon you should bump sushi-lib version before merging...

@andreamattavelli
Copy link
Collaborator Author

Reckon you should bump sushi-lib version before merging...

Absolutely, otherwise the build will fail since sushi-lib does not have Maven support.
Another point to solve before merging IMHO is pietrobraione/jbse#10. Otherwise mvn package will fail.

@pietrobraione
Copy link
Owner

Ack.

@pietrobraione pietrobraione merged commit 9036396 into pietrobraione:master Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants