Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] K-means #106

Open
wants to merge 4 commits into
base: clust_python
Choose a base branch
from
Open

[WIP] K-means #106

wants to merge 4 commits into from

Conversation

jbarnoud
Copy link
Collaborator

@jbarnoud jbarnoud commented Dec 2, 2015

To do:

  • convert the old API calls to the new ones
  • write unit tests
  • write the command line interface
  • document the API
  • document the CLI

@jbarnoud jbarnoud self-assigned this Dec 2, 2015
@jbarnoud jbarnoud added this to the 1.3 milestone Dec 2, 2015
@jbarnoud jbarnoud force-pushed the kmeans branch 3 times, most recently from 592a689 to e604336 Compare December 6, 2015 11:20
@HubLot HubLot mentioned this pull request Dec 14, 2015
8 tasks
@pierrepo
Copy link
Owner

pierrepo commented Apr 8, 2016

Dear @jbarnoud and @HubLot can you please complete this PR?

@HubLot
Copy link
Collaborator

HubLot commented Apr 8, 2016

I can manage the integration of the k-means into PBxplore (and documentation).
But before that, I have to know if the k-means implementation is correct and finished.

@jbarnoud
Copy link
Collaborator Author

jbarnoud commented Apr 8, 2016

I'll do it. I got stuck at testing if the implementation is correct as I
do not really have a reference to compare with.

On 08-04-16 13:58, Hub wrote:

I can manage the integration of the k-means into PBxplore (and
documentation).
But before that, I have to know if the k-means implementation is
correct and finished.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#106 (comment)

@alexdb27
Copy link
Contributor

alexdb27 commented Apr 8, 2016

simulated data do not work ?

@jbarnoud
Copy link
Collaborator Author

jbarnoud commented Apr 8, 2016

I got stuck at finding simulated data that were not too artificial to be
relevant. I'll have a new look at this this week-end.

On 08-04-16 14:27, Alexandre G. de Brevern wrote:

simulated data do not work ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#106 (comment)

@alexdb27
Copy link
Contributor

alexdb27 commented Apr 8, 2016

you have not simulated data ?

@jbarnoud
Copy link
Collaborator Author

jbarnoud commented Apr 8, 2016

I did some tests. I'll have to go back to it.

On 08-04-16 14:33, Alexandre G. de Brevern wrote:

you have not simulated data ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#106 (comment)

@pierrepo
Copy link
Owner

pierrepo commented Apr 8, 2016

Maybe if your implementation gives similar results to what is obtained with scikit-learn (http://scikit-learn.org/stable/modules/generated/sklearn.cluster.KMeans.html) it should be ok?

@jbarnoud
Copy link
Collaborator Author

jbarnoud commented Apr 8, 2016

On 08/04/16 15:14, Pierre Poulain wrote:

Maybe if your implementation gives similar results to what is obtained
with scikit-learn
(http://scikit-learn.org/stable/modules/generated/sklearn.cluster.KMeans.html)
it should be ok?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#106 (comment)

No because I used completely different definitions for the centers and
the distances.

@pierrepo pierrepo modified the milestones: 1.4, 1.3 Apr 8, 2016
Introduce a new module in analysis. That module was written pre-API
redesign so it refers to old construct and cannot work.

The module is added to the doc.

Some unit tests are introduced on the module.
@pierrepo
Copy link
Owner

Hi @jbarnoud Could you have a look to this WIP?

@alexdb27
Copy link
Contributor

hello, how is it ?

@pierrepo
Copy link
Owner

After discussion with @jbarnoud We probably keep this feature for another release of PBxplore.
@jbarnoud is it possible to remove all trace of clustering from the master branch?

@jbarnoud
Copy link
Collaborator Author

On 27/06/16 18:56, Pierre Poulain wrote:

After discussion with @jbarnoud https://github.com/jbarnoud We
probably keep this feature for another release of PBxplore.
@jbarnoud https://github.com/jbarnoud is it possible to remove all
trace of clustering from the master branch?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#106 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABUWuqBKnoyEhDSiLmJH6kl6hagYBJ8jks5qQACqgaJpZM4GtFZ1.

It is in my TODO list for tomorrow. In a miraculous universe where I
manage to follow my plans, there should be a PR very soon.

By the way, this PR is a working tool. You can play with it if PBkmeans
if you want to have fun.

@alexdb27
Copy link
Contributor

Ok
Le 27 juin 2016 18:56, "Pierre Poulain" [email protected] a écrit :

After discussion with @jbarnoud https://github.com/jbarnoud We probably
keep this feature for another release of PBxplore.
@jbarnoud https://github.com/jbarnoud is it possible to remove all
trace of clustering from the master branch?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#106 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AJWGcGKeufrGobRWYyrOEAZjBTqpafq3ks5qQACqgaJpZM4GtFZ1
.

@alexdb27
Copy link
Contributor

PR for what

@jbarnoud
Copy link
Collaborator Author

This PR (#106) implements PBkmeans.

I have a branch somewhere that makes hclust work with python only. But ward is not available because of an issue in scipy.

I will submit a PR to remove all traces of clustering in PBxplore. It is not very difficult to have something that will somehow group sequences, but I would like to assess the strength and drawbacks of the different algorithms rather than just releasing an algo at random.

@pierrepo
Copy link
Owner

pierrepo commented Jul 4, 2016

@jbarnoud can I add this branch to Pbxplore repo?

1 similar comment
@pierrepo
Copy link
Owner

pierrepo commented Jul 4, 2016

@jbarnoud can I add this branch to Pbxplore repo?

@jbarnoud
Copy link
Collaborator Author

jbarnoud commented Jul 4, 2016

On 04/07/16 15:18, Pierre Poulain wrote:

@jbarnoud https://github.com/jbarnoud can I add this branch to
Pbxplore repo?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#106 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABUWujqbww_TupmBiXBjPfLAphtZPRhzks5qSQgygaJpZM4GtFZ1.

Nobody reviewed it. Neither the code nor the science behind it.

@pierrepo
Copy link
Owner

pierrepo commented Jul 4, 2016

@jbarnoud but as a "dev_pbkmeans" branch? So that you can clean/remove the clustering from the master branch.

@jbarnoud
Copy link
Collaborator Author

jbarnoud commented Jul 4, 2016

Why not.
Le 4 juil. 2016 3:46 PM, Pierre Poulain [email protected] a écrit :@jbarnoud but as a "dev_pbkmeans" branch? So that you can clean/remove the clustering from the master branch.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

@HubLot HubLot mentioned this pull request Oct 11, 2016
3 tasks
@pierrepo pierrepo changed the base branch from master to clust_python December 21, 2016 13:03
@pierrepo
Copy link
Owner

Hi @jbarnoud
I changed the target branch for this PR.
Could you refresh the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants