Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refactor Inline Styles to Local CSS in Component Files #64

Merged
merged 7 commits into from
Jan 10, 2024
Merged

fix: Refactor Inline Styles to Local CSS in Component Files #64

merged 7 commits into from
Jan 10, 2024

Conversation

Arindam200
Copy link
Contributor

Description

Refactored inline styles in component files to utilize local CSS for improved maintainability and readability.

This PR fixes #37

Changes Made

  • Removed inline styles present within component files.
  • Introduced local CSS files corresponding to each component where necessary.
  • Updated the component logic to import and utilize the local CSS classes instead of inline styles.

@jwafu jwafu added project structure for changes to the project that adjust the file structure css styling for css related updates or changes labels Jan 8, 2024
@jwafu jwafu self-requested a review January 8, 2024 14:57
jwafu
jwafu suggested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@jwafu jwafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arindam200 there are a few changes here, can you make these updates?

src/app/components/Button/Button.tsx Outdated Show resolved Hide resolved
src/app/components/Button/button.css Outdated Show resolved Hide resolved
src/app/components/Header/Header.tsx Outdated Show resolved Hide resolved
src/app/components/TextInput/textinput.css Outdated Show resolved Hide resolved
src/app/components/Button/button.css Outdated Show resolved Hide resolved
@Arindam200
Copy link
Contributor Author

@Arindam200 there are a few changes here, can you make these updates?

Sure.

I'm updating this.

@Arindam200 Arindam200 requested a review from jwafu January 10, 2024 05:01
jwafu
jwafu approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@jwafu jwafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect :) thanks for the updates merging this now to support a ton of new work ! 👍

@jwafu jwafu merged commit 705dc12 into pieces-app:main Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwafu jwafu jwafu approved these changes

Assignees

@Arindam200 Arindam200

Labels
css styling for css related updates or changes project structure for changes to the project that adjust the file structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Inline Styles to Local CSS in Component Files
2 participants
@Arindam200 @jwafu