-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgraded the methods for Copilot using pieces-copilot-sdk #138
Merged
shivay-at-pieces
merged 11 commits into
pieces-app:main
from
VishalPawar1010:#123-Upgrade-the-method-for-Pieces-Copilot
Aug 27, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4a51006
feat: upgraded relevant methods
VishalPawar1010 914e21d
feat: url change
VishalPawar1010 c130f4a
feat: add select chat feature
VishalPawar1010 907ca97
feat: added config url
VishalPawar1010 ea2b9dc
feat: added getConvo Api
VishalPawar1010 ba76567
feat: show message for first question
VishalPawar1010 c946361
feat: first question response handling
VishalPawar1010 317302f
feat: added config for macos and windows
VishalPawar1010 1deeedf
feat: platform config changes
VishalPawar1010 a71c30a
feat: added platform settings
2ea0169
added changes
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VishalPawar1010 great work with this implementation. I was just wondering if you would like to also implement an additional functionality actually to list all of the conversations using the getConversations endpoint. on the UI. right now the back and forward buttons are not functionality. We can have a conversations list. and let the user select which conversation they wish to view. And you can use the piecesClient to then return that conversation ID and display the existing conversation in the Copilot chat window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we can remove the back and forward buttons and have a UI button for: choose copilot conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts @Arindam-at-Pieces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will implement this functinality to list conversations and give option to select then display selected conversation.
Do we have any plan to use TailwindCss in future for UI feature additions (like dropdown etc) like this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think we can definitely introduce Tailwind @VishalPawar1010
I think that is a larger discussion as part to restructure the UI / Revamp the entire project, so that can definitely be explored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then, until it is finalised I will implement UI in Vanilla Js + Css.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivay-at-pieces Added the mentioned functionality
Test video in Mac:
https://www.awesomescreenshot.com/video/29867394?key=d7c0a15d362babff9b160ae2e06c66ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VishalPawar1010 what I will recommend is if you can also display the messages of the specific chat that you have selected in the chat window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay sure. Will try to display message as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Test Video : https://www.awesomescreenshot.com/video/29878767?key=e661acd7694e4055f75144ae76d61c5d