Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug : fixed response formatting using rehype and ReactMarkdown #111

Conversation

VishalPawar1010
Copy link
Contributor

Description

This PR fixes #62

Resolved response formatting issue using rehype and ReactMarkdownlibrary

@VishalPawar1010 VishalPawar1010 changed the title #62 : fixed response formatting using rehype and ReactMarkdown bug : fixed response formatting using rehype and ReactMarkdown May 27, 2024
Copy link
Contributor

@shivay-at-pieces shivay-at-pieces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VishalPawar1010,

Thank you for your contribution! I encountered a type declaration issue when testing the changes locally. To resolve this, please ensure that the necessary type declarations are added. Specifically, you might need to add type declarations for ReactMarkdown and rehypeSanitize.

@VishalPawar1010
Copy link
Contributor Author

Hello @shivay-at-pieces , I have added specific type declarations for both ReactMarkdown and rehypeSanitize .
Please let me know for any.

Copy link
Contributor

@shivay-at-pieces shivay-at-pieces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

You might have to also take care for formatting the font color of the response, since it doesn't appear well currently in dark mode as seen in this screenshot.

@shivay-at-pieces
Copy link
Contributor

image Certain parts are not updated properly. I would suggest focus on changing the CSS right now for the Copilot message section

@VishalPawar1010
Copy link
Contributor Author

Yes, I am on it.

@VishalPawar1010
Copy link
Contributor Author

Hey @shivay-at-pieces , I have made required changes to resolve css/font-color conflicts.
Please have a look, It should work fine now.

@VishalPawar1010
Copy link
Contributor Author

In dark mode :
image

In light mode :
image

@mason-at-pieces
Copy link
Collaborator

@shivay-at-pieces we can close the older pr (#102 ) and review this one

@VishalPawar1010
Copy link
Contributor Author

@shivay-at-pieces please let me know, if we need any modifications/corrections for this PR.

Thanks

@mason-at-pieces mason-at-pieces self-requested a review June 12, 2024 15:14
@VishalPawar1010
Copy link
Contributor Author

VishalPawar1010 commented Jun 20, 2024

Just a heads up->
Hey @shivay-at-pieces , @mason-at-pieces :
If this PR looks good, could you please merge it ?
If having any modifications please let me know.
Thanks

@shivay-at-pieces shivay-at-pieces merged commit 2114db4 into pieces-app:main Jul 8, 2024
1 check passed
@VishalPawar1010
Copy link
Contributor Author

Thank you for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copilot Response Formatting Issue
3 participants