-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : implemented login and logout functionality #103
feat : implemented login and logout functionality #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please Remove the unnecessary spaces, the rest looks good
@Arindam200 I have removed most of the unnecessary spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall implementation looks great. But we would like to also share some additional details when the user is logged in.
For instance, when the user logs in, you can show their name at the top. In additional, can we reduce the size of the buttons for login / log out.
In addition, we should have an option to be able to use the example without being logged in. So that option to login should appear in the main screen
Sure, will look into below details for this PR
Thanks for the critical review |
Also @VishalPawar1010 right now, if the user is already logged into Pieces, then you should automatically enter the application and it should be able to identify that. That is that the user should only see the Login screen if Pieces OS isn't actually having a logged in state |
Noted down the additional points to be considered -
I will look into this issue once I am done with issue #62 . |
@shivay-at-pieces @VishalPawar1010 Is there a reason we are requiring users to authenticate? You can utilize every feature besides things like sharing without authenticating. Id rather let users use everything without authenticating but they can if they want |
Hey @shivay-at-pieces, as my previous PR is merged, I can move forward for this PR now. As Mason asked in previous comment, please let me know if we need to continue work on this issue. Thanks |
Hey @shivay-at-pieces , @Arindam200 , this PR is ready for review.
Please let me know for any mofifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a much better implementation @VishalPawar1010!
Thanks for the contribution. Just one small request: when the application loads for the first time or even if you refresh, the login button appears for a few seconds and only then you see the user being logged in with the logout button.
To ensure that the application knows whether the user is logged in as soon as it loads or refreshes, you can use the useEffect hook to check the login status immediately upon mounting
Thank you for the critical review. |
Handled the mentioned case. |
Thanks this looks great |
Description
This PR fixes #91 : Implemented login and logout functinality to Pieces OS
Here is test recording : https://www.awesomescreenshot.com/video/27665717?key=10fe1fa66bd6c3d3febe8b72935ee5f4
Regarding changes for _indicator.firstElementChild : It was showing following error at runtime, thus updated the code to resolve it.