fix:corrected pynvim installation instruction in neovim plugin docs #563
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -29,7 +29,7 @@ A few things to note before you start installing the Pieces Neovim Plugin: | |||
| - The Python based Neovim plugins requires the `pynvim` Python package, which is not included in the default Neovim installation. You can install it by running the following command: | |||
|
|
|||
| ```bash | |||
| pip install pynvim | |||
| sudo apt install python3-pynvim | |||
There was a problem hiding this comment.
Hey @Debajyati thanks for your contribution, I will recommend that we can add this in an info section in the docs since not everyone will use a Debian based system. For mac users they can still run the current command.
::: info
:::
There was a problem hiding this comment.
Okay I didn't know about mac because I never used one. But I know that it is not just Debian based systems. In any linux distribution you would need to manually install any python package with the system package manager( unless you are inside a virtual environment and adding the libraries as dependency). Like in Arch Linux the command would be -
sudo pacman -S python3-pynvimthe system package manager would change with the flags/options but the package would always be python3-pynvim.
I mentioned Debian Based because Ubuntu is debian based and I read somewhere in the Docs that Pieces currently supports only Ubuntu and all of its derivatives. So all of the supported systems share apt as the package manager.
And the largest user base of Neovim are Linux Users -
So, hey! @shivay-at-pieces I think that it would be better if we make it a two part section.
For MacOS users -
pip install pynvim
If you use Debian/Ubuntu -
sudo apt install python3-pynvim
What do you think?
There was a problem hiding this comment.
Yeah this makes sense @Debajyati
|
@shivay-at-pieces @Debajyati isn't #567 related to that and should be done in one PR? |
|
I mean I was confused! I asked some people about when someone ( a maintainer ) reviews the PR and requests some changes then should I create a new branch and send a new PR from it or do just the changes in the same branch and send a PR? They suggested me to make a new PR from a fresh new branch. So this is why I did this. |
|
@Debajyati ah okay. If the pieces team wants it that way, then it's fine. Just found it confusing if you have multiple pr's for a nearly identical issue. |
|
Hey just asking, what do of a PR that is not going to get merged? |
|
you could close that pr and work on the new pr only. Otherwise about the status we need to wait until the team takes a look at this. |
|
Ok, thanks. So I will close this PR and make the changes you requested in the new PR I send last time. I will remove Debian from the line I added in the docs in the new PR. Because only Ubuntu 22+ and Ubuntu based distros are supported. Is that all good! |
#562
This PR updates the documentation to provide the correct installation command for pynvim on Debian-based systems. Previously, the documentation suggested using
pip install pynvim, which always leads to errors in externally managed environments.By using
sudo apt install python3-pynvim, users can ensure thatpynvimis installed correctly and can be used by the plugin.