Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete improvements #587

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add autocomplete improvements #587

wants to merge 2 commits into from

Conversation

markusand
Copy link

Add two slight improvements to autocomplete:

  1. Add show and hide functionality when mouse hover or focus
  2. Chips keep their size no matter the autocmplete is set to block or inline flex

Marc Vilella added 2 commits April 23, 2019 13:30
I don't understand the functionality of the .on-focus class. While the docs say 'You may add the is-focused class to form-autocomplete-input to make it appear as focus state' it actually only manages shadow and border color.

I added an .autocomplete-dropdown class that hides the menu and shows it on hover or on focus. There is also a translate reset to prevent .menu hiding when mouse hovers the gap between .form-autocmplete-input and .menu
Chips keep their size and don't grow when autocomplete is set to oneline

&:hover > .menu,
&:focus-within > .menu { display: block; }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains trailing whitespace

}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains trailing whitespace

flex: 0 0 auto;
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains trailing whitespace

@davestewart davestewart mentioned this pull request Sep 20, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants