Ensure the user agent is always a string

picqer · Mar 10, 2020 · 276ae6f · 276ae6f
1 parent d44ff46
commit 276ae6f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Client.php b/src/Client.php
@@ -108,9 +108,9 @@ public static function setHttp(HttpInterface $http): void
     /**
      * Set the user agent reported with API calls.
      *
-     * @param string|null $userAgent
+     * @param string $userAgent
      */
-    public static function setUserAgent(?string $userAgent): void
+    public static function setUserAgent(string $userAgent): void
     {
         static::$userAgent = $userAgent;
     }
@@ -132,7 +132,7 @@ private static function addAuthenticationOptions(array $options): array
 
     private static function addUserAgentOptions(array $options): array
     {
-        if (static::$userAgent === null) {
+        if (static::$userAgent === null || strlen(static::$userAgent) === 0) {
             return $options;
         }
 

diff --git a/tests/ClientTest.php b/tests/ClientTest.php
@@ -20,7 +20,7 @@ public function setup(): void
 
     public function tearDown(): void
     {
-        Client::setUserAgent(null);
+        Client::setUserAgent('');
     }
 
     public function testAuthenticateWithCredentials()