True LL #51
Merged
True LL #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a warning on the man page for the weird results.
Also, removed conflicting definitions of trueLL found in the
sads-methods.R
NOTE: pkg install throws a warning about the siglist for
trueLL("histogram", ...) because histogram is not a valid S4 class,
but the code works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, see discussion on issue #5 for suggestion on how to deal with trueLL, but I suggest pulling this branch now to avoid a bug that's causing the package installation to crash on older versions of R. In the older version of this package there are two different "forms" of trueLL, one being a function and one being a S4 generic. Both are exported in the NAMESPACE, which causes older releases of R to crash with the cryptic message: