Makes the graphs for TopClients & TopDomains behave like ClientsOverTime depending on Privacy Level #3071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Makes the graphs for TopClients & TopDomains behave like ClientsOverTime depending on Privacy Level
How does this PR accomplish the above?:
take the behavior found here on Line 28
web/scripts/pi-hole/js/index.js
Lines 28 to 31 in 60ca1c7
and adds it to the functions for TopClients on L296 & TopDomains on L355
original
web/scripts/pi-hole/js/index.js
Lines 296 to 300 in 60ca1c7
web/scripts/pi-hole/js/index.js
Lines 355 to 359 in 60ca1c7
after
https://github.com/mwoolweaver/web/blob/4fc448d31108dcb9d9d0c7a9695ee3016baf15fb/scripts/pi-hole/js/index.js#L297-L301
https://github.com/mwoolweaver/web/blob/4fc448d31108dcb9d9d0c7a9695ee3016baf15fb/scripts/pi-hole/js/index.js#L357-L361
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase
)