Apply suggestions from code review

Signed-off-by: Christian König <[email protected]>
pi-hole · Jul 8, 2024 · 1897f68 · 1897f68
1 parent 33cdb85
commit 1897f68
Showing 1 changed file with 42 additions and 40 deletions.
diff --git a/scripts/pi-hole/js/index.js b/scripts/pi-hole/js/index.js
@@ -295,31 +295,32 @@ function updateTopClientsTable(blocked) {
     // Add note if there are no results (e.g. privacy mode enabled)
     if (jQuery.isEmptyObject(data.clients)) {
       clienttable.append('<tr><td colspan="3"><center>- No data -</center></td></tr>');
-    } else {
-      // Populate table with content
-      data.clients.forEach(function (client) {
-        // Sanitize client
-        let clientname = client.name;
-        if (clientname.length === 0) clientname = client.ip;
-        url =
-          '<a href="queries.lp?client_ip=' +
-          encodeURIComponent(client.ip) +
-          '">' +
-          utils.escapeHtml(clientname) +
-          "</a>";
-        percentage = (client.count / sum) * 100;
-
-        // Add row to table
-        clienttable.append(
-          "<tr> " +
-            utils.addTD(url) +
-            utils.addTD(client.count) +
-            utils.addTD(utils.colorBar(percentage, sum, style)) +
-            "</tr> "
-        );
-      });
+      return;
     }
 
+    // Populate table with content
+    data.clients.forEach(function (client) {
+      // Sanitize client
+      let clientname = client.name;
+      if (clientname.length === 0) clientname = client.ip;
+      url =
+        '<a href="queries.lp?client_ip=' +
+        encodeURIComponent(client.ip) +
+        '">' +
+        utils.escapeHtml(clientname) +
+        "</a>";
+      percentage = (client.count / sum) * 100;
+
+      // Add row to table
+      clienttable.append(
+        "<tr> " +
+          utils.addTD(url) +
+          utils.addTD(client.count) +
+          utils.addTD(utils.colorBar(percentage, sum, style)) +
+          "</tr> "
+      );
+    });
+
     // Hide overlay
     overlay.hide();
   }).fail(function (data) {
@@ -352,25 +353,26 @@ function updateTopDomainsTable(blocked) {
     // Add note if there are no results (e.g. privacy mode enabled)
     if (jQuery.isEmptyObject(data.domains)) {
       domaintable.append('<tr><td colspan="3"><center>- No data -</center></td></tr>');
-    } else {
-      // Populate table with content
-      data.domains.forEach(function (item) {
-        // Sanitize domain
-        domain = encodeURIComponent(item.domain);
-        // Substitute "." for empty domain lookups
-        urlText = domain === "" ? "." : domain;
-        url = '<a href="queries.lp?domain=' + domain + '">' + urlText + "</a>";
-        percentage = (item.count / sum) * 100;
-        domaintable.append(
-          "<tr> " +
-            utils.addTD(url) +
-            utils.addTD(item.count) +
-            utils.addTD(utils.colorBar(percentage, sum, style)) +
-            "</tr> "
-        );
-      });
+      return;
     }
 
+    // Populate table with content
+    data.domains.forEach(function (item) {
+      // Sanitize domain
+      domain = encodeURIComponent(item.domain);
+      // Substitute "." for empty domain lookups
+      urlText = domain === "" ? "." : domain;
+      url = '<a href="queries.lp?domain=' + domain + '">' + urlText + "</a>";
+      percentage = (item.count / sum) * 100;
+      domaintable.append(
+        "<tr> " +
+          utils.addTD(url) +
+          utils.addTD(item.count) +
+          utils.addTD(utils.colorBar(percentage, sum, style)) +
+          "</tr> "
+      );
+    });
+
     overlay.hide();
   }).fail(function (data) {
     apiFailure(data);