Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update how to modifying lighttpd configuration when you use caddy as web server #1012

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xavierskip
Copy link
Contributor

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

use /etc/lighttpd/external.conf is invalid. Changing default listening port of lighttpd in Raspberry Pi OS no longer honors external.conf

How does this PR accomplish the above?:

in folder /etc/lighttpd/conf-available/ create your config file and link it to folder /etc/lighttpd/conf-enabled.

solution can't bind to socket: [::]:80 error : The file lighttpd.conf is loading /usr/share/lighttpd/use-ipv6.pl before conf-enabled folder, thus using the default server.port.

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 1672757
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/66067c025947160008625680
😎 Deploy Preview https://deploy-preview-1012--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xavierskip xavierskip closed this Mar 29, 2024
@xavierskip xavierskip reopened this Mar 29, 2024
@lynnpepin
Copy link

Came here to contribute the same thing, happy to see someone has it :) I don't think the linking isn actually necessary though; I was able to do this just by creating a file /etc/lighttpd/conf-enabled/map_to_1080.conf. (The filename can be arbitrary.)

@xavierskip
Copy link
Contributor Author

Came here to contribute the same thing, happy to see someone has it :) I don't think the linking isn actually necessary though; I was able to do this just by creating a file /etc/lighttpd/conf-enabled/map_to_1080.conf. (The filename can be arbitrary.)

No. Your approach is more labor-saving. but mine is common. Otherwise, why design two folders? conf-enabled and conf-available

@gstrauss
Copy link
Contributor

FYI: this was reported upstream and fixed a year ago in Debian's configuration. Debian and derivatives are always slow in picking up changes and improvements.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1035926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants