Log which interface is actually used when a different was configured #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DL6ER <[email protected]>
…interfaces to extend their scope to interface aliases. The man page does not mention that they are limited to "real" interfaces and stop working once an alias interface is specified (even if valid). Signed-off-by: DL6ER <[email protected]>
DL6ER
force-pushed
the
using_interface_instead
branch
from
d68cf8b
to
f48372b
Compare
|
Rebased & submitted https://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2022q1/016058.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is alternative PR to #5. In contrast to #5, this PR does not fix the bug of listening on both interfaces when asked only to listen on the alias interface (see other PR for details). Instead, it only adds logging for which interface is actually used when a different was configured.
I personally prefer #5 but want to be prepared if it is rejected because fixing the bug breaks backwards-compatibility in some edge-cases.