Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link related spaces / properties directly #73

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

jamesdabbs
Copy link
Member

@jamesdabbs jamesdabbs commented Nov 6, 2023

fixes #67

🔬 Review Notes

This looks like a lot of lines changed, but almost all of it is trimming down and (auto)formatting the end-to-end fixtures file. Ignore that one 😜

@jamesdabbs jamesdabbs self-assigned this Nov 6, 2023
Copy link

cloudflare-workers-and-pages bot commented Nov 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0ac184d
Status: ✅  Deploy successful!
Preview URL: https://04c20cad.topology.pages.dev
Branch Preview URL: https://related-links.topology.pages.dev

View logs

this should significantly speed up end-to-end testing time and cut
down on intermittent timeouts caused by waiting for deduction to
fully complete
@jamesdabbs jamesdabbs marked this pull request as ready for review November 6, 2023 03:57
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the newly added regression test.


it('links to properties', () => {
cy.visit('spaces/S000004/properties')
deduce()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we are increasingly adding these "wait for deduction" blocks, we want to make sure that deduction run stays fast (and – importantly – within the timeout).

@jamesdabbs jamesdabbs merged commit ce242af into main Nov 6, 2023
3 checks passed
@jamesdabbs jamesdabbs deleted the related-links branch November 6, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider linking directly to properties in space/property list
1 participant