feat: move to sveltekit #71
Conversation
Deploying with
|
| Latest commit: |
ccc703d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6f02133.topology.pages.dev |
| Branch Preview URL: | https://sveltekit.topology.pages.dev |
Replacing svelte-router based routing. This commit makes a minimal set of changes required to get things functional. We'll follow up with other changes to move things around, make them more idiomatically sveltekit, and start leveraging some of its features a little better.
|
@StevenClontz – I'd love to get your thoughts here. I will fix up the Cypress tests, but I think that'll be easier to do after doing some more substantial reworking of the app booting and data loading process. I'm weakly inclined to break that up into several different PRs into the |
|
Things that probably don't surprise you based on my messing with the public preview: changing branches updates the data but doesn't re-run deductions. Then refreshing loses the choice of an alternate branch, and doesn't re-run deductions until I hit reset. (EDIT: I'll try to remember to use this preview next time I want to look up things on main, to see if there's any breakage when not messing with branches.) Unless I can pitch in with the refactor directly, I defer to you on how you want to proceed with it, and I'm happy to keep trying to use preview deploys for reviewing/contributing to pi-base/data. But if you want to collaborate on any pi-base/web development, I probably want to sync up and may have a stronger opinion on the workflow. |
In cases where the sync completes immediately, the unsubscribe callback isn't fully initialized. We were checking for this logically, but the const declaration prevents access. var is more permissive and defaults to undefined, so the && check works as intended.
jamesdabbs
force-pushed
the
sveltekit
branch
10 times, most recently
from
be0df25
to
da862f2
Compare
Moving to sveltekit complicates trying to intercept network calls, as they can happen either on the client or server side. The approach we're taking here is to serve the fixture data from the local preview server during testing.
|
Thanks for your progress on this James. I'll have the community take a peek (unless there's a reason to wait) |
Replacing svelte-router based routing. This commit makes a minimal set of changes required to get things functional. We'll follow up with other changes to move things around, make them more idiomatically sveltekit, and start leveraging some of its features a little better.
Fixes #65