show trait description on trait, not space (#76)

* show trait description on trait, not space * test: add test coverage for trait show body --------- Co-authored-by: James Dabbs <[email protected]>
pi-base · Nov 7, 2023 · 78ab5bf · 78ab5bf
1 parent 8a4bd46
commit 78ab5bf
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/packages/viewer/cypress/e2e/space.spec.ts b/packages/viewer/cypress/e2e/space.spec.ts
@@ -2,6 +2,14 @@ import { deduce, setup } from '../support'
 
 beforeEach(setup)
 
+function clickTraitFor(name: string) {
+ cy.get('.related-traits')
+ .contains(name)
+ .closest('tr')
+ .find('.bi-check')
+ .click()
+}
+
 it('links to properties', () => {
  cy.visit('spaces/S000004/properties')
  deduce()
@@ -15,7 +23,7 @@ it('links to traits', () => {
  cy.visit('spaces/S000004/properties')
  deduce()
 
- cy.contains('Semiregular').closest('tr').find('.bi-check').click()
+ clickTraitFor('Semiregular')
 
  cy.location('pathname').should('eq', '/spaces/S000004/properties/P000010')
 })
@@ -30,3 +38,11 @@ it('filters traits', () => {
  .first()
  .should('have.text', '16 Compact ')
 })
+
+it('displays trait descriptions', () => {
+ cy.visit('spaces/S000001')
+
+ clickTraitFor('Discrete')
+
+ cy.contains('By definition of discrete')
+})
diff --git a/packages/viewer/cypress/fixtures/main.min.json b/packages/viewer/cypress/fixtures/main.min.json
@@ -6088,7 +6088,7 @@
  "refs": [
 
  ],
- "description": "-"
+ "description": "By definition of discrete"
  },
  {
  "uid": "T024776",

diff --git a/packages/viewer/src/components/Traits/Show.svelte b/packages/viewer/src/components/Traits/Show.svelte
@@ -50,9 +50,9 @@
  <Proof {space} {...proof} />
  {:else if meta}
  <section class="description">
- <Typeset body={space.description} />
+ <Typeset body={meta.description} />
  </section>
-
+ <h3>References</h3>
  <References references={meta.refs} />
  {/if}
 {:catch}