Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Integrate Loguru #53

Closed
wants to merge 3 commits into from
Closed

Conversation

maestroque
Copy link
Contributor

References: physiopy/phys2bids#461

Integrate Loguru for all log types, including info messages, warnings and exception catching

Proposed Changes

  • Migrate all message logging to a single logger interface with Loguru. This includes console print()s, warnings and exceptions

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@maestroque maestroque changed the title Add loguru to setup.cfg [WIP] Integrate Loguru May 13, 2024
@maestroque maestroque self-assigned this May 13, 2024
@maestroque
Copy link
Contributor Author

I suggest we close this, since it's really outdated

@maestroque maestroque closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant