Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLI): On pull error, print the API response [TSI-1750] #463

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

jablan
Copy link
Collaborator

@jablan jablan commented Nov 3, 2023

Now when there's an error on CLI pull, the users are left in dark as the server response (which usually explains the reason for the error) is not printed out. This PR addresses that.

https://phrase.atlassian.net/browse/TSI-1750

Related: phrase/phrase-cli#126

@jablan jablan requested a review from theSoenke November 3, 2023 12:52
@jablan jablan changed the title feat(CLI): On pull error, print the API response feat(CLI): On pull error, print the API response [TSI-1750] Nov 3, 2023
Copy link
Collaborator

@theSoenke theSoenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really helpful

@jablan jablan merged commit b0b6ed1 into master Nov 3, 2023
13 checks passed
@jablan jablan deleted the output-error-response branch November 3, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants