Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eqq (===) and nee (!==) operators #94

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

jacekkarczmarczyk
Copy link
Contributor

fixes #93

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Potherca @kornelski any opinions?

@@ -1350,9 +1350,15 @@ this page has been readed ${page/countRead} times"/>
<code>==</code> : <code>EQ</code> (等しい)
</para></listitem>
<listitem><para>
<code>===</code> : <code>EQQ</code> (厳密に等しい)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how to validate this change 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust me bro, ai and Google gave me the same result :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't trust either of those sources :-P

<code>!=</code> : <code>NE</code> (等しくない)
</para></listitem>
<listitem><para>
<code>!==</code> : <code>NEE</code> (厳密に等しくない)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how to validate this change 😁

@Ocramius Ocramius added this to the 1.9.0 milestone Apr 17, 2024
@Ocramius
Copy link
Member

🚢

@Ocramius Ocramius self-assigned this Apr 17, 2024
@Ocramius Ocramius merged commit 9d0a1eb into phptal:1.9.x Apr 17, 2024
9 checks passed
@Ocramius
Copy link
Member

Thanks @jacekkarczmarczyk!

@jacekkarczmarczyk jacekkarczmarczyk deleted the feat/#93-eqq-nee branch April 17, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EQQ/NEE
3 participants